Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed error handling of map module #174

Merged

Conversation

AtomicLiquid
Copy link
Member

The map module should now give a more accurate description in the logs when an error occurs. It will also let you know if the map version already exist within the database.

@AtomicLiquid AtomicLiquid linked an issue Jul 23, 2023 that may be closed by this pull request
examples/SimpleModule/SimpleModule.csproj Show resolved Hide resolved
src/Modules/MapsModule/Controllers/MapsController.cs Outdated Show resolved Hide resolved
tests/Modules/MapsModule.Tests/MapsControllerTests.cs Outdated Show resolved Hide resolved
tests/Modules/MapsModule.Tests/MapsControllerTests.cs Outdated Show resolved Hide resolved
tests/EvoSC.Common.Tests/Services/MapServiceTests.cs Outdated Show resolved Hide resolved
tests/EvoSC.Common.Tests/Services/MapServiceTests.cs Outdated Show resolved Hide resolved
@AtomicLiquid AtomicLiquid force-pushed the 79-expand-map-module-with-more-accurate-exceptions branch from 54f9469 to 801676e Compare July 27, 2023 07:35
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

56.4% 56.4% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@AtomicLiquid AtomicLiquid merged commit 9d1926d into master Aug 3, 2023
3 checks passed
@AtomicLiquid AtomicLiquid deleted the 79-expand-map-module-with-more-accurate-exceptions branch August 3, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand Map module with more accurate exceptions
2 participants